Skip to content

Conversation

@the-phinet
Copy link
Contributor

I always thought the -v flag was broken, because it would spit out a half dozen blank lines for every request. Turns out it was white text on a white background. This pr should fix that for most people who have the same issue.

@the-phinet the-phinet force-pushed the colors branch 2 times, most recently from 7861134 to c47e173 Compare August 1, 2025 03:51
@missionfloyd
Copy link
Contributor

        COLORS_DEFAULT["debug"] = "0;39"
        COLORS_DEFAULT["info"] = "1;39"

This should be all that's necessary.

@the-phinet
Copy link
Contributor Author

You're cool with changing the default colours?

@mikf
Copy link
Owner

mikf commented Aug 2, 2025

I would be OK with it if they produced identical or at least similar results, but 0;39 is not at all the same as the current 0;37.

_

@the-phinet
Copy link
Contributor Author

the-phinet commented Aug 2, 2025

For reference, this is what outputs look like on my end:

        | dark | light
--------|------|------------
release | okay | unreadable
--------|------|------------
colors  | okay | okay
image

@missionfloyd
Copy link
Contributor

The termios module isn't available on windows.

0;37 is much brighter here. I guess it would ultimately depend on the color scheme.

@the-phinet
Copy link
Contributor Author

the-phinet commented Aug 3, 2025

Interesting. I'll change it to default windows to dark mode, if I can't find an alternative

Edit: done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants