Support 1.20.2, 1.20.3 and 1.20.4

[oliwoli]

I think this should be fine. Tested too. Can I get a LGTM? Or just merge it :)

[gemini-code-assist]

Hello @oliwoli, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

Summary of Changes

This pull request updates the project to support Minecraft versions 1.20.2 to 1.20.4. The changes primarily involve updating version numbers and dependencies in the .minepkg-lock.toml, gradle.properties, and minepkg.toml files to reflect the new Minecraft versions. The author has tested the changes and is requesting a review and merge.

Highlights

• Minecraft Version Update: The pull request updates the supported Minecraft versions from 1.20.0-1.20.1 to 1.20.2-1.20.4.
• Dependency Updates: The pull request updates the fabric and libgui dependencies to versions compatible with Minecraft 1.20.2-1.20.4.
• Mapping Update: The pull request updates the yarn mappings to 1.20.2+build.4.

Changelog

Click here to see the changelog

• .minepkg-lock.toml
  • Updated minecraft version to 1.20.4 (line 7).
  • Updated mapping to 1.20.4+build.3 (line 9).
  • Updated fabric version to 0.97.2+1.20.4.mpkg.1 (line 15).
  • Updated Sha256 checksum for fabric (line 19).
  • Updated url for fabric download (line 20).
• gradle.properties
  • Updated yarn_mappings to 1.20.2+build.4 (line 7).
  • Updated libgui_version to 9.2.2+1.20.2 (line 17).
  • Updated minecraft_version_range to >=1.20.2 <=1.20.4 (line 19).
• minepkg.toml
  • Updated minecraft requirement to >=1.20.2 <=1.20.4 (line 16).

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in issue comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

---

Did you know?

The Fabric Loader is a popular mod loader for Minecraft, known for its lightweight and modular design, allowing for faster updates and better compatibility compared to some other mod loaders.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

The pull request updates the Minecraft version and related dependencies to support versions 1.20.2 to 1.20.4. The changes seem straightforward and necessary for compatibility. However, I have a few observations regarding the versioning and dependency updates.

Summary of Findings

• Inconsistent Minecraft Version Updates: The minecraft_version in gradle.properties is still set to 1.20, while other files are updated to 1.20.2 or 1.20.4. This inconsistency could lead to confusion or issues during the build process.
• Dependency Versioning: The fabric_version is not updated, even though other dependencies like libgui_version are. It's important to ensure all dependencies are compatible with the target Minecraft version.

Merge Readiness

While the changes seem necessary for updating the Minecraft version, the inconsistencies in versioning across different files raise concerns. I recommend addressing these inconsistencies before merging. I am unable to directly approve this pull request, and other reviewers should also review this code before merging.

[oliwoli]

@gemini-code-assist you happy now?

[gemini-code-assist]

Glad to hear it! The changes look good and the updates to the Minecraft versions and dependencies seem correct. Thanks for addressing the previous feedback, @oliwoli.

[Fourmisain]

Was just about to hit that merge button! 😄

[Fourmisain]

Don't like how minepkg bump turns

# Dependencies
fabric_version=0.91.6+1.20.2
libgui_version=9.2.2+1.20.2

minecraft_version_range= >=1.20.2 <=1.20.4
java_version=17

into

# Dependencies
fabric_version=0.91.6+1.20.2
libgui_version=9.2.2+1.20.2
minecraft_version_range=>=1.20.2 <=1.20.4
java_version=17

Give me back that empty line!

[oliwoli]

Was just about to hit that merge button! 😄

muhaha :D It was too tempting to press it

Give me back that empty line!

Mhm... Right, right. It's the little annoying things that get ya. Adding it to feature requests

[Fourmisain]

It also removed the space you added to minecraft_version_range= .
In a previous commit you can even see it nuke all spaces alltogether ac2967f (at least I'm pretty sure that was minepkg bump).
Ideally it should just change the version number and nothing else.