Skip to content

Conversation

@Zargess
Copy link
Collaborator

@Zargess Zargess commented Jul 16, 2025

Testing ConversationHandler class to 100% test and pitest coverage

@Zargess Zargess requested a review from miniwolf July 16, 2025 10:27
@Zargess Zargess changed the base branch from develop to dev/zargess/server-tests July 16, 2025 13:28
Copy link
Owner

@miniwolf miniwolf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Zargess Zargess force-pushed the dev/zargess/server-tests branch from cb7c198 to 1095490 Compare July 16, 2025 14:37
@Zargess Zargess force-pushed the dev/zargess/conversationhandler-tests branch from 3033926 to 1f660b6 Compare July 16, 2025 14:48
@Zargess Zargess force-pushed the dev/zargess/server-tests branch from 1095490 to f4a4741 Compare August 10, 2025 12:12
@Zargess Zargess force-pushed the dev/zargess/conversationhandler-tests branch 2 times, most recently from dbbec29 to 0d4b68a Compare August 10, 2025 12:17
@Zargess Zargess changed the title Dev/zargess/conversationhandler tests Conversationhandler class tests Aug 10, 2025
@Zargess
Copy link
Collaborator Author

Zargess commented Aug 10, 2025

Made the following changes:

  • Fixed flaky test ServerConversationHandlerTests#whenServerIsShuttingDown_ThenConversationHandlerThreadShouldBeInterrupted
  • Added test to verify isRunning in ServerConfigTests
  • Added test to verify isRunning in OutputWorkerTests
  • Added test to verify isRunning in InputWorkerTests

The three last points is to improve pitest coverage

@Zargess Zargess requested a review from miniwolf August 10, 2025 12:30
Copy link
Owner

@miniwolf miniwolf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Base automatically changed from dev/zargess/server-tests to develop September 16, 2025 14:58
Testing the ConversationHandler class to 100% test and pitest coverage
## Move running field

Removed the running fields for all Workers and the Server class. Now the running field is contained in the CheckFieldRunningStrategy.

## Stop IsRunningStrategy

The IsRunningStrategy now has a function to stop the strategy. In the CheckFieldRunningStrategy it sets the running field to false.
@Zargess Zargess force-pushed the dev/zargess/conversationhandler-tests branch from 0d4b68a to a0a5691 Compare September 16, 2025 15:00
@Zargess Zargess merged commit b8e24f7 into develop Sep 16, 2025
3 checks passed
@Zargess Zargess deleted the dev/zargess/conversationhandler-tests branch September 16, 2025 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants