Include tagName when providing invalid attr value and class name when defining invalid attrsSchema #103
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tdumitrescu
reviewed
Aug 21, 2020
Member
tdumitrescu
left a comment
tdumitrescu
left a comment
There was a problem hiding this comment.
Looks like there's a test to fix
| // Ensure attr type is valid | ||
| const attrType = attrSchema.type; | ||
| if (!ATTR_TYPE_DEFAULTS.hasOwnProperty(attrType)) { | ||
| throw new Error( |
Member
There was a problem hiding this comment.
Suggested change
| throw new Error( | |
| this._logError(`attrsSchema error in`, this); | |
| throw new Error( |
jakewski
changed the title
jakewski
commented
Aug 21, 2020
lib/component.js
Outdated
| // Ensure attr type is valid | ||
| const attrType = attrSchema.type; | ||
| if (!ATTR_TYPE_DEFAULTS.hasOwnProperty(attrType)) { | ||
| this._logError(`attrsSchema definition error in`, this); |
Contributor
Author
There was a problem hiding this comment.
not sure _logError would still be useful in this situation since it will always throw on initialization
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.