Bug/all images use flexbox #325
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…se there is a caption
…aption if its limited by page width
…n resizing images based on width we should resize the image not the figure but i cant think that through now. Also dont make pmb_images flex as it breaks their floating... better to just not use pmb_image in pro I think
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
otherwise captions get bumped to the next screen.
trouble is inline images. and right now this only works for "pmb-image"s
what are pmb-images anyway? can be on a figure, div
they're weird is what. Should become
pmb-unbreakable(no line breaks inside),pmb-resized(bigger than max image height so shrunk),pmb-snappable(can be snapped; as indicated by the design).