capability: add ListKnown, ListSupported; deprecate List #153
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kolyshkin
added a commit
to kolyshkin/sys
that referenced
this pull request
Sep 20, 2024
This is a draft pending moby#151, moby#152, moby#153 merge. TODO: fix the release date. Signed-off-by: Kir Kolyshkin <[email protected]>
kolyshkin
added a commit
to kolyshkin/sys
that referenced
this pull request
Sep 20, 2024
This is a draft pending moby#151, moby#152, moby#153 merge. TODO: fix the release date. Signed-off-by: Kir Kolyshkin <[email protected]>
kolyshkin
changed the title
kolyshkin
added a commit
to kolyshkin/sys
that referenced
this pull request
Sep 21, 2024
This is a draft pending moby#151, moby#152, moby#153 merge. TODO: fix the release date. Signed-off-by: Kir Kolyshkin <[email protected]>
kolyshkin
added a commit
to kolyshkin/sys
that referenced
this pull request
Sep 21, 2024
This is a draft pending moby#151, moby#152, moby#153 merge. TODO: fix the release date. Signed-off-by: Kir Kolyshkin <[email protected]>
kolyshkin
force-pushed
the
list-enh
branch
2 times, most recently
from
e767c87 to
7384a8a
Compare
kolyshkin
changed the title
|
@thaJeztah PTAL |
According to [1], the generated files should contain a comment which matches the following regexp: ^// Code generated .* DO NOT EDIT\.$ Fix accordingly. [1]: https://pkg.go.dev/cmd/go#hdr-Generate_Go_files_by_processing_source Signed-off-by: Kir Kolyshkin <[email protected]>
|
Rebased |
kolyshkin
commented
Sep 25, 2024
Apparently, most users of capability.List wants the list of supported capabilities (i.e. they go on to exclude capabilities above the last known one). Let's provide ListSupported to such users. Also, provide ListKnown, and deprecate List. Finally, amend LastCap documentation with a link to ListSupported, as this is what most users are using it for. Signed-off-by: Kir Kolyshkin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apparently, most users of capability.List wants the list of supported
capabilities (i.e. they go on to exclude capabilities above the last
known one).
Let's provide
ListSupportedto such users.Also, provide
ListKnown, and deprecateList.Finally, amend LastCap documentation with a link to ListSupported,
as this is what most users are using it for.
Draft until #152 is merged; TODO: amendLastCapdoc to mentionListSupported.