Skip to content

Conversation

@codeboyzhou
Copy link
Contributor

@codeboyzhou codeboyzhou commented Dec 11, 2025

  1. Make scheduler fields final in client and server transports
  2. Explicitly specify UTF-8 charset when creating InputStreamReader instances
  3. Remove method protocolVersions() in class StdioServerTransportProvider

Motivation and Context

  1. For better immutability
  2. (SpotBugs check) Ensure consistent character encoding to avoid potential problem
  3. Method protocolVersions() implementation is identical to its super class, no need to override it

How Has This Been Tested?

Just run ./mvnw test

Breaking Changes

Not involved

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update

Checklist

  • I have read the MCP Documentation
  • My code follows the repository's style guidelines
  • New and existing tests pass locally
  • I have added appropriate error handling
  • I have added or updated documentation as needed

Additional context

Not involved

…readers

Make scheduler fields final in client and server transports for better immutability.
Explicitly specify UTF-8 charset when creating InputStreamReader instances to ensure consistent character encoding.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant