Python weather server - Add the ruff llinter and apply it #81
+82
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weather-server-python/pyproject.toml
Outdated
Comment on lines
43
to
46
| [tool.ruff.lint.per-file-ignores] | ||
| "__init__.py" = ["F401"] | ||
| "tests/server/fastmcp/test_func_metadata.py" = ["E501"] | ||
| "tests/shared/test_progress_notifications.py" = ["PLW0603"] |
Member
There was a problem hiding this comment.
These are for the Python SDK only, right?
Collaborator
Author
There was a problem hiding this comment.
@jonathanhefner ah, yes, thank you for noticing! Removed.
jonathanhefner
approved these changes
Dec 12, 2025
Member
|
Thank you, @a-akimov! |
Collaborator
Author
|
Thank you, @jonathanhefner ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Linters help keeping code clean and unified. I've added ruff to the Python server (and then will add to the Python client as well).
When choosing which linting rules to follow, I copied the one that our community is already using for developing the Python SDK (https://github.com/modelcontextprotocol/python-sdk/blob/main/pyproject.toml) to make sure we keep Python projects consistent.
How Has This Been Tested?
Locally.
Breaking Changes
No
Types of changes
Checklist
Additional context
N/a