Fix multi-gpu amd-smi parsing #60
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For newer amd-smi versions that return this gpu_data key, we also need to have that at the top level since we use the length of the return array to determine if there are multiple-gpus
modularbot
pushed a commit
to modular/modular
that referenced
this pull request
Sep 23, 2025
To pull in modular/rules_mojo#60 MODULAR_ORIG_COMMIT_REV_ID: e74bac7f5990dd3b7335d9f5f1c3b8a3ba66cd4a
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For newer amd-smi versions that return this gpu_data key, we also need
to have that at the top level since we use the length of the return
array to determine if there are multiple-gpus