Ignore macOS GPUs before macOS 15 #68
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently mojo requires metal 3.2, which is only macOS 15+. Unfortunately the system_profiler output doesn't contain this specificity so the easiest thing for us to do is check the major OS version first and just bail on that.
modularbot
pushed a commit
to modular/modular
that referenced
this pull request
Dec 17, 2025
Pulls in modular/rules_mojo#68 MODULAR_ORIG_COMMIT_REV_ID: 638369a6c9b65d93ace4242825e2f0fb72a1a16f
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently mojo requires metal 3.2, which is only macOS 15+.
Unfortunately the system_profiler output doesn't contain this
specificity so the easiest thing for us to do is check the major OS
version first and just bail on that.