Skip to content

Conversation

@lpradovera
Copy link
Member

No description provided.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So this should only impact the To header, not the actual address to which packets are sent.

We also need to do the same for the rest of the dialog, so I guess this can't actually be an option to invite...

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could split the two, if there is an option To header is changed, otherwise it uses the same setup as the rest.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are things that SippyCup should probably never try to do. The goal of SippyCup is to make SIPp manageable. If we go on to support every permutation of possibilites that SIPp allows, we're going to end up in a deep hole.

@benlangfeld can you tell me how often you anticipate running into this issue, where the remote SIP address differs from the address to which packets are sent? And if so, is this not already handled by having the invite instruction take an address which may be different from the address specified in the general test options?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fairly often with multi-tenant systems, and no, because later expectations/sent messages will revert to the wrong To header.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are we using the name remote_sip_address instead of something like to?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants