-
Notifications
You must be signed in to change notification settings - Fork 4
Split estimate_acint in two private functions #12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR refactors the estimate_acint function by extracting its internal logic into two separate private functions for better modularity and methodological testing. The main function now delegates to _scan_frequencies for the frequency scanning phase and _marginalize_properties for the marginalization phase. Additionally, the helper function _finalize_props is renamed to _finalize_properties for consistency.
Key Changes
- Split
estimate_acintinto two private functions:_scan_frequencies(performs frequency cutoff scan) and_marginalize_properties(computes weighted averages) - Renamed
_finalize_propsto_finalize_propertiesfor naming consistency
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <[email protected]>
|
@gozdetoraman Could you check whether this all makes sense in line with how we explained things in the papers? I think this better reflects how the algorithm works, and it also allows from some more validation of our assumptions. (I'll discuss this up later.) |
| Parameters | ||
| ---------- | ||
| See :func:`estimate_acint` for parameter descriptions other than `history`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| See :func:`estimate_acint` for parameter descriptions other than `history`. | |
| See :func:`estimate_acint` for parameter descriptions, except for `history`. |
Thanks for the improvements! Indeed this matches better with the descriptions in the papers, just made some small suggestions for the docstrings. |
Co-authored-by: Gözde Toraman <[email protected]>
|
Thanks for the suggestions. Will merge soon. |
This is an internal reorganization of
estimate_acint. Having separate functions for the frequency scan and the marginalization is helpful for methodological testing.