Remove $facet in top level group stages #449
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Awesome, thank you and thanks @asya999 |
aclark4life
requested changes
Nov 20, 2025
Collaborator
aclark4life
left a comment
aclark4life
left a comment
There was a problem hiding this comment.
Can you add a test, particular one that would test something that breaks in the Django admin with QE (even though QE is not merged yet)?
timgraham
reviewed
Nov 20, 2025
| } | ||
| ) | ||
| pipeline.append({"$group": group}) | ||
| # It may be a bug, $$NOW has to be called to be reachable in the rest of the pipeline. |
Collaborator
There was a problem hiding this comment.
Please add link to the SERVER ticket and add an explanatory comment about the purpose of the $unionWith clause.
I think we can also mention it in the release notes as a performance improvement since the team said $facet prevents the use of optimizations.
Contributor
|
Can you provide, in this PR, an example of what the removal of $facet makes the new query signatures look like? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.