Use BTreeSet instead of Vec in pallet_inflation_rewards #1410
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And improve struct docs a bit
Contributor
WASM runtime size check:Compared to target branchdancebox runtime: 1904 KB (+8 KB) flashbox runtime: 1128 KB (no changes) ✅ dancelight runtime: 2668 KB (-4 KB) 🚨 starlight runtime: 2556 KB (-8 KB) 🚨 container chain template simple runtime: 1472 KB (no changes) ✅ container chain template frontier runtime: 1832 KB (no changes) ✅ |
Contributor
Coverage Report@@ Coverage Diff @@
## master tomasz-refactor-inflationrewards +/- ##
====================================================================
+ Coverage 69.75% 69.76% +0.01%
Files 542 542
+ Lines 72268 72278 +10
====================================================================
+ Hits 50409 50419 +10
Misses 21859 21859
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And improve struct docs a bit