[ QA ] redirect 페이지 일렉트론 분기 처리 #317
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adds refresh token handling for the redirect page in an Electron environment and updates authentication utilities accordingly.
- Added getRefreshToken and setRefreshToken functions in auth.ts.
- Modified the RedirectPage to handle refreshToken extraction and storage.
- Introduced a comment in the API client regarding future usage of the localStorage refresh token.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/shared/utils/auth.ts | Added functions for retrieving and setting the refresh token. |
| src/shared/apisV2/client.ts | Added a comment regarding future improvements to refresh token usage. |
| src/pages/RedirectPage/RedirectPage.tsx | Updated token extraction logic to support Electron-specific hash parsing. |
Comment on lines
+43
to
44
| // NOTE: 추후에 로컬스토리지에 저장된 refreshToken을 사용하게끔 고치는 것이 필요할수있음 | ||
| const { data } = await postReissueToken(); |
There was a problem hiding this comment.
Implement usage of the localStorage refreshToken (using getRefreshToken) in the token reissue logic to improve consistency with the authentication flow.
Suggested change
| // NOTE: 추후에 로컬스토리지에 저장된 refreshToken을 사용하게끔 고치는 것이 필요할수있음 | |
| const { data } = await postReissueToken(); | |
| // Use the refresh token from localStorage for token reissue | |
| const refreshToken = getRefreshToken(); | |
| const { data } = await postReissueToken(refreshToken); |
|
|
||
| useEffect(() => { | ||
| const params = new URLSearchParams(search); | ||
| // @ts-expect-error |
There was a problem hiding this comment.
Consider adding proper type definitions for window.electron to handle the Electron-specific branch instead of using @ts-expect-error.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔥 Related Issues
✅ 작업 리스트
🔧 작업 내용
🧐 새로 알게된 점
🤔 궁금한 점
📸 스크린샷 / GIF / Link