-
Notifications
You must be signed in to change notification settings - Fork 112
Attempt to fix the iOS CI build #176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
mosra
wants to merge
7
commits into
master
Choose a base branch
from
fix-ios-build
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
New build system and it's clearly worse than the old. Typical 2020s, yes.
This also means CORRADE_TARGET_IOS_SIMULATOR is no longer set for simulator builds. Let's see how many test breakages that causes. Well actually the tests don't run on iOS at all now, so even the breakages would be better than the current state.
mosra
added a commit
to mosra/magnum-plugins
that referenced
this pull request
Aug 17, 2023
Also disabling iOS tests until mosra/corrade#176 is resolved.
mosra
added a commit
that referenced
this pull request
Aug 17, 2023
So the build doesn't fail every time. Will be enabled again once #176 is resolved.
mosra
added a commit
to mosra/magnum
that referenced
this pull request
Aug 18, 2023
Also disable iOS tests until mosra/corrade#176 is resolved.
mosra
added a commit
to mosra/magnum
that referenced
this pull request
Aug 18, 2023
Also disable iOS tests until mosra/corrade#176 is resolved.
mosra
added a commit
to mosra/magnum
that referenced
this pull request
Aug 18, 2023
Also disable iOS tests until mosra/corrade#176 is resolved.
sthalik
pushed a commit
to sthalik/corrade
that referenced
this pull request
Aug 29, 2023
So the build doesn't fail every time. Will be enabled again once mosra#176 is resolved.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #176 +/- ##
==========================================
+ Coverage 98.22% 98.41% +0.19%
==========================================
Files 140 137 -3
Lines 11896 10871 -1025
==========================================
- Hits 11685 10699 -986
+ Misses 211 172 -39 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This does a bunch of things:
CMAKE_SYSTEM_NAMEto iOS does most of the workCMAKE_OSX_SYSROOTneeds to be set toiphonesimulator(doesn't need to be a path, apparently) to make the right libraries foundxctestexecutable that's found byFindXCTestis working only for native macOS executables, which makes all tests breakAttempted solutions:
xcodebuild test, and the futile attempts to speed that damn thing up, liketest-without-buildinginstead oftestand using-only-test:, but even then each test run takes 30+ secondsxctestexecutable,/Applications/Xcode-12.5.1.app/Contents/Developer/Platforms/iPhoneSimulator.platform/Developer/Library/Xcode/Agents/xctest, unfortunately it doesn't work out-of-the box either and relies on a ton of undocumented env vars set "just right"All env vars supplied to it from
xcodebuildare the following, as can be seen inArgumentsTestin the CI output, and if all are set it works:Things to do:
xctestexecutable to be taken for the simulatorUseCorradexcodebuild testor withxctest, the user still needs to supply an iPhone version, and whether it's a device or simulator. That's done withCORRADE_TESTSUITE_XCTEST_DESTINATIONnow.CORRADE_TARGET_IOS_SIMULATORCMake var as it's impossible to detect in CMakeSIMULATOR_UDIDnot existing was for the original hackyxctestrun, the change toSIMULATOR_MAINSCREEN_SCALEis totally random and it now XPASSes certain tests)