feat: add breadcrumbs to folder setting #296
Open
+42
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
hezhizhen
force-pushed
the
add-breadcrumbs-in-folder-settings
branch
2 times, most recently
from
ea06b7b to
7a30132
Compare
Contributor
Author
|
@gschier any ideas? |
hezhizhen
force-pushed
the
add-breadcrumbs-in-folder-settings
branch
from
7a30132 to
98210b0
Compare
hezhizhen
force-pushed
the
add-breadcrumbs-in-folder-settings
branch
from
98210b0 to
8afb35e
Compare
Member
|
@hezhizhen I'm okay with this but I'm not crazy about the visual design (looks too much like an input field). I don't have any ideas to make it better, but two things to try:
|
Contributor
Author
I see. I'll update this PR and screenshots based on your suggestion later when I have enough free time to work on it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preview: