Fix cookies not being persisted after HTTP requests #328
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cookies received from Set-Cookie headers were stored in the in-memory CookieStore but never saved back to the database. Each subsequent request would reload cookies from the database, losing any cookies received from previous responses. This fix extracts cookies from the in-memory store after each request completes and persists them back to the cookie jar in the database.
There was a problem hiding this comment.
Pull request overview
This PR fixes a critical bug where cookies received from HTTP responses were not being persisted to the database. Cookies were stored in the in-memory CookieStore during requests but were lost when subsequent requests reloaded cookies from the database.
Key changes:
- Added cookie persistence logic after HTTP request completion
- Cookies are now extracted from the in-memory store and saved back to the database after each request
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cookies received from Set-Cookie headers were stored in the in-memory
CookieStore but never saved back to the database. Each subsequent request
would reload cookies from the database, losing any cookies received from
previous responses.
This fix extracts cookies from the in-memory store after each request
completes and persists them back to the cookie jar in the database.