Implement custom cookie handling in HTTP transaction layer #334
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove dependency on reqwest for cookie handling by implementing custom cookie store and management in the yaak-http crate: - Add new cookies.rs module with CookieStore for storing and matching cookies based on RFC 6265 domain/path rules - Update HttpTransaction to inject Cookie headers before requests and parse Set-Cookie headers from responses - Maintain cookies across redirect chains - Update http_request.rs to use new CookieStore instead of reqwest_cookie_store - Update WebSocket cookie handling to use new CookieStore - Remove reqwest_cookie_store dependency from all crates - Add comprehensive tests for cookie injection, parsing, and redirects
Add validation to prevent cookies from being set for overly broad single-component domains like .com or .org, while allowing localhost variants (localhost, 127.0.0.1, ::1) for local development.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove dependency on reqwest for cookie handling by implementing custom
cookie store and management in the yaak-http crate:
cookies based on RFC 6265 domain/path rules
parse Set-Cookie headers from responses
reqwest_cookie_store