-
Notifications
You must be signed in to change notification settings - Fork 691
Feature: New POLYLINE command in Pilz planner for space trajectory generation #3610
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
AimanHaidar
wants to merge
30
commits into
moveit:main
Choose a base branch
from
AimanHaidar:feature/free-path-generator
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+1,144
−8
Open
Changes from 22 commits
Commits
Show all changes
30 commits
Select commit
Hold shift + click to select a range
c86e3b2
Format max_velocity and max_acceleration for YAML output as float
AimanHaidar 38aac46
make use of max_cartesian_speed in MotionSequenceRequest
AimanHaidar 7d70a27
use feature in circ command
AimanHaidar 0bb71f2
organize into function
AimanHaidar b28883e
Merge branch 'fix/joint-limits-crash' into dev
AimanHaidar ce9099d
add free path planner using composite kdl path
AimanHaidar a0bc8e4
fix include files and add it to plugin
AimanHaidar 4e62e81
convert to roundedComposite
AimanHaidar e9f63ae
fix bug andadd check of near start point to curve tip
AimanHaidar 4008bdc
fix bug in set max cart speed before set of path
AimanHaidar b8e8de3
Merge branch 'feature/use-max-cartesian-speed' into feature/free-path…
AimanHaidar 99f146b
add check request validation
AimanHaidar 24d27ce
add function to compute the max rounding circle radius
AimanHaidar 84a8e94
add close points check to avoid Not_Feasable error
AimanHaidar 749d7e4
add helper class for generate free paths
AimanHaidar 440a77d
clean code and add copyright!
AimanHaidar c6a0389
Merge branch 'moveit:main' into feature/free-path-generator
AimanHaidar 7e08974
handle colinear points errors
AimanHaidar 5072fbd
correct error massages and fix bug
AimanHaidar 9fc413a
restrict the rounding radius to not exceed KDL epsilon
AimanHaidar 616d427
fix bug
AimanHaidar ab5d654
fix:compute rounding(blend) radius after filtering near points
AimanHaidar 5f7a8ba
change name to polyline
AimanHaidar d5ce36c
change files' names
AimanHaidar b1df424
rename
AimanHaidar 61c8742
fix jazzy-ci issue
AimanHaidar 0120591
add test for the cartesian max speed
AimanHaidar ef3294f
Revert "Format max_velocity and max_acceleration for YAML output as f…
AimanHaidar 7bd69b7
Merge branch 'main' into feature/free-path-generator
AimanHaidar d60d8dd
fix clang-tidy failures for rolling
AimanHaidar File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
50 changes: 50 additions & 0 deletions
50
...lz_industrial_motion_planner/include/pilz_industrial_motion_planner/path_free_generator.h
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,50 @@ | ||
|
|
||
| /********************************************************************* | ||
| * All MoveIt 2 headers have been updated to use the .hpp extension. | ||
| * | ||
| * .h headers are now autogenerated via create_deprecated_headers.py, | ||
| * and will import the corresponding .hpp with a deprecation warning. | ||
| * | ||
| * imports via .h files may be removed in future releases, so please | ||
| * modify your imports to use the corresponding .hpp imports. | ||
| * | ||
| * See https://github.com/moveit/moveit2/pull/3113 for extra details. | ||
| *********************************************************************/ | ||
| /********************************************************************* | ||
| * Software License Agreement (BSD License) | ||
| * | ||
| * Copyright (c) 2018 Pilz GmbH & Co. KG | ||
| * Copyright (c) 2025 Aiman Haidar | ||
| * All rights reserved. | ||
| * | ||
| * Redistribution and use in source and binary forms, with or without | ||
| * modification, are permitted provided that the following conditions | ||
| * are met: | ||
| * | ||
| * * Redistributions of source code must retain the above copyright | ||
| * notice, this list of conditions and the following disclaimer. | ||
| * * Redistributions in binary form must reproduce the above | ||
| * copyright notice, this list of conditions and the following | ||
| * disclaimer in the documentation and/or other materials provided | ||
| * with the distribution. | ||
| * * Neither the name of Pilz GmbH & Co. KG nor the names of its | ||
| * contributors may be used to endorse or promote products derived | ||
| * from this software without specific prior written permission. | ||
| * | ||
| * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS | ||
| * "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT | ||
| * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS | ||
| * FOR A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE | ||
| * COPYRIGHT OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, | ||
| * INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, | ||
| * BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; | ||
| * LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER | ||
| * CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT | ||
| * LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN | ||
| * ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE | ||
| * POSSIBILITY OF SUCH DAMAGE. | ||
| *********************************************************************/ | ||
|
|
||
| #pragma once | ||
| #pragma message(".h header is obsolete. Please use the .hpp header instead.") | ||
| #include <pilz_industrial_motion_planner/path_free_generator.hpp> | ||
99 changes: 99 additions & 0 deletions
99
..._industrial_motion_planner/include/pilz_industrial_motion_planner/path_free_generator.hpp
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,99 @@ | ||
| /********************************************************************* | ||
| * Software License Agreement (BSD License) | ||
| * | ||
| * Copyright (c) 2018 Pilz GmbH & Co. KG | ||
| * Copyright (c) 2025 Aiman Haidar | ||
| * All rights reserved. | ||
| * | ||
| * Redistribution and use in source and binary forms, with or without | ||
| * modification, are permitted provided that the following conditions | ||
| * are met: | ||
| * | ||
| * * Redistributions of source code must retain the above copyright | ||
| * notice, this list of conditions and the following disclaimer. | ||
| * * Redistributions in binary form must reproduce the above | ||
| * copyright notice, this list of conditions and the following | ||
| * disclaimer in the documentation and/or other materials provided | ||
| * with the distribution. | ||
| * * Neither the name of Pilz GmbH & Co. KG nor the names of its | ||
| * contributors may be used to endorse or promote products derived | ||
| * from this software without specific prior written permission. | ||
| * | ||
| * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS | ||
| * "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT | ||
| * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS | ||
| * FOR A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE | ||
| * COPYRIGHT OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, | ||
| * INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, | ||
| * BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; | ||
| * LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER | ||
| * CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT | ||
| * LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN | ||
| * ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE | ||
| * POSSIBILITY OF SUCH DAMAGE. | ||
| *********************************************************************/ | ||
|
|
||
| #pragma once | ||
|
|
||
| #include <kdl/path.hpp> | ||
| #include <kdl/path_roundedcomposite.hpp> | ||
| #include <kdl/rotational_interpolation_sa.hpp> | ||
| #include <kdl/utilities/error.h> | ||
|
|
||
| #include <memory> | ||
|
|
||
| namespace pilz_industrial_motion_planner | ||
| { | ||
| /** | ||
| * @brief Generator class for KDL::Path_RoundedComposite from different free path | ||
| * representations | ||
| */ | ||
| class PathFreeGenerator | ||
| { | ||
| public: | ||
| /** | ||
| * @brief set the path free from waypoints | ||
| * | ||
| */ | ||
| static std::unique_ptr<KDL::Path> freeFromWaypoints(const KDL::Frame& start_pose, | ||
| const std::vector<KDL::Frame>& waypoints, | ||
| KDL::RotationalInterpolation* rot_interpo, double smoothness, | ||
| double eqradius); | ||
|
|
||
| /** | ||
| * @brief compute the maximum rounding radius from KDL::Path_RoundedComosite | ||
| * @param waypoints_: waypoints defining the path | ||
| * @param smoothness: smoothness level [0..1] scaling the maximum blend radius | ||
| * @return maximum blend radius | ||
| */ | ||
| static std::vector<KDL::Frame> filterWaypoints(const KDL::Frame& start_pose, const std::vector<KDL::Frame>& waypoints); | ||
| static double computeBlendRadius(const std::vector<KDL::Frame>& waypoints_, double smoothness); | ||
| static void checkConsecutiveColinearWaypoints(const KDL::Frame& p1, const KDL::Frame& p2, const KDL::Frame& p3); | ||
|
|
||
| private: | ||
| PathFreeGenerator(){}; // no instantiation of this helper class! | ||
|
|
||
| static constexpr double MIN_SEGMENT_LENGTH{ 0.2e-3 }; | ||
| static constexpr double MIN_SMOOTHNESS{ 0.01 }; | ||
| static constexpr double MAX_SMOOTHNESS{ 0.99 }; | ||
| static constexpr double MIN_COLINEAR_NORM{ 1e-9 }; | ||
| }; | ||
|
|
||
| class ErrorMotionPlanningColinearConsicutiveWaypoints : public KDL::Error_MotionPlanning | ||
| { | ||
| public: | ||
| const char* Description() const override | ||
| { | ||
| return "Three collinear consecutive waypoints." | ||
| " A Free Path cannot be created."; | ||
| } | ||
| int GetType() const override | ||
| { | ||
| return ERROR_CODE_COLINEAR_CONSECUTIVE_WAYPOINTS; | ||
| } // LCOV_EXCL_LINE | ||
|
|
||
| private: | ||
| static constexpr int ERROR_CODE_COLINEAR_CONSECUTIVE_WAYPOINTS{ 3104 }; | ||
| }; | ||
|
|
||
| } // namespace pilz_industrial_motion_planner |
50 changes: 50 additions & 0 deletions
50
..._industrial_motion_planner/include/pilz_industrial_motion_planner/planning_context_free.h
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,50 @@ | ||
|
|
||
| /********************************************************************* | ||
| * All MoveIt 2 headers have been updated to use the .hpp extension. | ||
| * | ||
| * .h headers are now autogenerated via create_deprecated_headers.py, | ||
| * and will import the corresponding .hpp with a deprecation warning. | ||
| * | ||
| * imports via .h files may be removed in future releases, so please | ||
| * modify your imports to use the corresponding .hpp imports. | ||
| * | ||
| * See https://github.com/moveit/moveit2/pull/3113 for extra details. | ||
| *********************************************************************/ | ||
| /********************************************************************* | ||
| * Software License Agreement (BSD License) | ||
| * | ||
| * Copyright (c) 2018 Pilz GmbH & Co. KG | ||
| * Copyright (c) 2025 Aiman Haidar | ||
| * All rights reserved. | ||
| * | ||
| * Redistribution and use in source and binary forms, with or without | ||
| * modification, are permitted provided that the following conditions | ||
| * are met: | ||
| * | ||
| * * Redistributions of source code must retain the above copyright | ||
| * notice, this list of conditions and the following disclaimer. | ||
| * * Redistributions in binary form must reproduce the above | ||
| * copyright notice, this list of conditions and the following | ||
| * disclaimer in the documentation and/or other materials provided | ||
| * with the distribution. | ||
| * * Neither the name of Pilz GmbH & Co. KG nor the names of its | ||
| * contributors may be used to endorse or promote products derived | ||
| * from this software without specific prior written permission. | ||
| * | ||
| * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS | ||
| * "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT | ||
| * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS | ||
| * FOR A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE | ||
| * COPYRIGHT OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, | ||
| * INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, | ||
| * BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; | ||
| * LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER | ||
| * CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT | ||
| * LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN | ||
| * ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE | ||
| * POSSIBILITY OF SUCH DAMAGE. | ||
| *********************************************************************/ | ||
|
|
||
| #pragma once | ||
| #pragma message(".h header is obsolete. Please use the .hpp header instead.") | ||
| #include <pilz_industrial_motion_planner/planning_context_free.hpp> |
68 changes: 68 additions & 0 deletions
68
...ndustrial_motion_planner/include/pilz_industrial_motion_planner/planning_context_free.hpp
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,68 @@ | ||
| /********************************************************************* | ||
| * Software License Agreement (BSD License) | ||
| * | ||
| * Copyright (c) 2018 Pilz GmbH & Co. KG | ||
| * Copyright (c) 2025 Aiman Haidar | ||
| * All rights reserved. | ||
| * | ||
| * Redistribution and use in source and binary forms, with or without | ||
| * modification, are permitted provided that the following conditions | ||
| * are met: | ||
| * | ||
| * * Redistributions of source code must retain the above copyright | ||
| * notice, this list of conditions and the following disclaimer. | ||
| * * Redistributions in binary form must reproduce the above | ||
| * copyright notice, this list of conditions and the following | ||
| * disclaimer in the documentation and/or other materials provided | ||
| * with the distribution. | ||
| * * Neither the name of Pilz GmbH & Co. KG nor the names of its | ||
| * contributors may be used to endorse or promote products derived | ||
| * from this software without specific prior written permission. | ||
| * | ||
| * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS | ||
| * "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT | ||
| * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS | ||
| * FOR A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE | ||
| * COPYRIGHT OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, | ||
| * INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, | ||
| * BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; | ||
| * LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER | ||
| * CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT | ||
| * LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN | ||
| * ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE | ||
| * POSSIBILITY OF SUCH DAMAGE. | ||
| *********************************************************************/ | ||
|
|
||
| #pragma once | ||
|
|
||
| #include <pilz_industrial_motion_planner/limits_container.hpp> | ||
|
|
||
| #include <rclcpp/rclcpp.hpp> | ||
|
|
||
| #include <moveit/planning_interface/planning_interface.hpp> | ||
| #include <moveit/planning_interface/planning_response.hpp> | ||
|
|
||
| #include <atomic> | ||
| #include <thread> | ||
|
|
||
| #include <pilz_industrial_motion_planner/planning_context_base.hpp> | ||
| #include <pilz_industrial_motion_planner/trajectory_generator_free.hpp> | ||
|
|
||
| namespace pilz_industrial_motion_planner | ||
| { | ||
| MOVEIT_CLASS_FORWARD(PlanningContext); | ||
|
|
||
| /** | ||
| * @brief PlanningContext for obtaining Free trajectories | ||
| */ | ||
| class PlanningContextFree : public pilz_industrial_motion_planner::PlanningContextBase<TrajectoryGeneratorFree> | ||
| { | ||
| public: | ||
| PlanningContextFree(const std::string& name, const std::string& group, const moveit::core::RobotModelConstPtr& model, | ||
| const pilz_industrial_motion_planner::LimitsContainer& limits) | ||
| : pilz_industrial_motion_planner::PlanningContextBase<TrajectoryGeneratorFree>(name, group, model, limits) | ||
| { | ||
| } | ||
| }; | ||
|
|
||
| } // namespace pilz_industrial_motion_planner |
50 changes: 50 additions & 0 deletions
50
...rial_motion_planner/include/pilz_industrial_motion_planner/planning_context_loader_free.h
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,50 @@ | ||
|
|
||
| /********************************************************************* | ||
| * All MoveIt 2 headers have been updated to use the .hpp extension. | ||
| * | ||
| * .h headers are now autogenerated via create_deprecated_headers.py, | ||
| * and will import the corresponding .hpp with a deprecation warning. | ||
| * | ||
| * imports via .h files may be removed in future releases, so please | ||
| * modify your imports to use the corresponding .hpp imports. | ||
| * | ||
| * See https://github.com/moveit/moveit2/pull/3113 for extra details. | ||
| *********************************************************************/ | ||
| /********************************************************************* | ||
| * Software License Agreement (BSD License) | ||
| * | ||
| * Copyright (c) 2018 Pilz GmbH & Co. KG | ||
| * Copyright (c) 2025 Aiman Haidar | ||
| * All rights reserved. | ||
| * | ||
| * Redistribution and use in source and binary forms, with or without | ||
| * modification, are permitted provided that the following conditions | ||
| * are met: | ||
| * | ||
| * * Redistributions of source code must retain the above copyright | ||
| * notice, this list of conditions and the following disclaimer. | ||
| * * Redistributions in binary form must reproduce the above | ||
| * copyright notice, this list of conditions and the following | ||
| * disclaimer in the documentation and/or other materials provided | ||
| * with the distribution. | ||
| * * Neither the name of Pilz GmbH & Co. KG nor the names of its | ||
| * contributors may be used to endorse or promote products derived | ||
| * from this software without specific prior written permission. | ||
| * | ||
| * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS | ||
| * "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT | ||
| * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS | ||
| * FOR A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE | ||
| * COPYRIGHT OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, | ||
| * INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, | ||
| * BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; | ||
| * LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER | ||
| * CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT | ||
| * LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN | ||
| * ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE | ||
| * POSSIBILITY OF SUCH DAMAGE. | ||
| *********************************************************************/ | ||
|
|
||
| #pragma once | ||
| #pragma message(".h header is obsolete. Please use the .hpp header instead.") | ||
| #include <pilz_industrial_motion_planner/planning_context_loader_free.hpp> |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we should add new
.hheader files.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, I will delete them