Bugfix FXIOS-13896 ⁃ [iOS 26] The Done button color in Edit bookmarks menu is not consistent (not blue) #30130
+162
−50
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… menu is not consistent (not blue)
🥇 Perfect PR sizeSmaller PRs are easier to review. Thanks for making life easy for reviewers! ✨ 🙌 Friday high-fiveThanks for pushing us across the finish line this week! 🙌 ❌ Per-file test coverage gateThe following changed file(s) are below 35.0% coverage:
Client.app: Coverage: 37.24
Generated by 🚫 Danger Swift against 1594197 |
There was a problem hiding this comment.
Overall looks great to me @dicarobinho great work, just some small nits comment
| @State var borderColor: Color = .clear | ||
| @State var textFieldBackgroundColor: Color = .clear | ||
| @State var barButtonColor: Color = .clear | ||
| @State var saveButtonColor: Color = .clear |
There was a problem hiding this comment.
Can we add directly ThemeableView from ComponentLibrary so we can simplify a lot this code ? cc @razvanlitianu ?
| case .bookmarks(state: .mainView), .bookmarks(state: .inFolder): | ||
| bottomRightButton.title = .BookmarksEdit | ||
| if #available(iOS 26.0, *) { | ||
| bottomRightButton.tintColor = themeManager.getCurrentTheme(for: windowUUID).colors.textPrimary |
There was a problem hiding this comment.
instead of querying the theme all time, can we just add it to a variable theme in and just pass the color ?
| case .bookmarks(state: .itemEditMode): | ||
| topRightButton.title = .SettingsAddCustomEngineSaveButtonText | ||
| if #available(iOS 26.0, *) { | ||
| topRightButton.tintColor = themeManager.getCurrentTheme(for: windowUUID).colors.textAccent |
| if #available(iOS 26.0, *) { | ||
| content | ||
| .foregroundColor( | ||
| !isEnabled ? saveDisableStateColor : |
There was a problem hiding this comment.
Can we make this easier to read ? Also with the ThemeableView we can just pass the Theme there
dicarobinho
requested review from
lmarceau
and removed request for
FilippoZazzeroni
lmarceau
requested review from
FilippoZazzeroni
and removed request for
lmarceau
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Tickets
Jira ticket
Github issue
💡 Description
Every Done/Save button from an edit screen should have tint color textAccent
Every Done/Save button from a normal screen should have tint color textPrimary
🎥 Demos
Demo
📝 Checklist