-
Notifications
You must be signed in to change notification settings - Fork 3.1k
Bump FXIOS [Dependencies] Update to Glean v66.0.1 #30206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Build failed on the unit tests |
|
@badboy what Xcode version do you have? I've had a similar issue in the past with dependencies not loaded in Xcode 16.2, we're nowadays using Xcode 26 |
The test The values returned by Any idea why the returned |
Latest. It turns out that I missed updating the version in |
|
This uncovered another small bug in the Glean |
🥇 Perfect PR sizeSmaller PRs are easier to review. Thanks for making life easy for reviewers! ✨ ❌ Per-file test coverage gateThe following changed file(s) are below 35.0% coverage:
Generated by 🚫 Danger Swift against e90aaa7 |
issammani
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM ! I will let @lmarceau do a final pass and merge 😄
|
🚀 PR merged to |
Focus already uses Glean follows semver, so major version upgrades usually include breaking changes (though we use the same version across all target languages, so the breaking changes might not apply). Still that will require human intervention some of the time, but the update process itself could be automated. |
My Xcode refuses to actually update the dependencies, it just spins and does nothing (and sometimes crashes). So this PR is not actually complete or tested.I appreciate if someone could help with that.