Skip to content

Conversation

@cyndichin
Copy link
Contributor

@cyndichin cyndichin commented Oct 30, 2025

📜 Tickets

Jira ticket
Github issue

💡 Description

Add initial recent searches UI by creating new section with list of recent searches.

  • Updates the zero search to consider showing if either recent or trending searches is enabled.
  • We also only show this state if the user is not in private mode.

🎥 Demos

simulator_screenshot_E2E3BC72-BD7B-42E8-AA49-0B484B73498F

📝 Checklist

  • I filled in the ticket numbers and a description of my work
  • I updated the PR name to follow our PR naming guidelines
  • I ensured unit tests pass and wrote tests for new code
  • If working on UI, I checked and implemented accessibility (Dynamic Text and VoiceOver)
  • If adding telemetry, I read the data stewardship requirements and will request a data review
  • If adding or modifying strings, I read the guidelines and will request a string review from l10n
  • If needed, I updated documentation and added comments to complex code

@cyndichin cyndichin changed the title Cc/fxios 13648 add recent searches to initial UI Add FXIOS-13648 [Trending Searches] initial recent searches UI Oct 30, 2025
@mobiletest-ci-bot
Copy link

mobiletest-ci-bot commented Oct 30, 2025

Messages
📖 Project coverage: 38.91%

💪 Quality guardian

2 tests files modified. You're a champion of test coverage! 🚀

🥇 Perfect PR size

Smaller PRs are easier to review. Thanks for making life easy for reviewers! ✨

🦊 BrowserViewController Check

We’re tracking the size of BrowserViewController.swift to keep it healthy.

  • ✨ Change in file size: +5 lines

❌ Per-file test coverage gate

The following changed file(s) are below 35.0% coverage:

File Coverage Required
firefox-ios/Client/Frontend/Browser/BrowserViewController/Views/BrowserViewController.swift 32.5% 35.0%
firefox-ios/Client/Frontend/Browser/Search/SearchViewController.swift 4.3% 35.0%

Client.app: Coverage: 37.11

File Coverage
BrowserViewController.swift 32.45% ⚠️
SearchViewController.swift 4.32% ⚠️
AddressToolbarContainer.swift 45.01% ⚠️
SearchViewModel.swift 69.09%
RecentSearchProvider.swift 88.0%

Generated by 🚫 Danger Swift against d6f905d

@cyndichin cyndichin force-pushed the cc/FXIOS-13648_add-recent-searches-to-initial-UI branch 2 times, most recently from e40b43f to 5457de6 Compare October 30, 2025 16:58
@cyndichin cyndichin requested a review from issammani October 30, 2025 16:59
@cyndichin
Copy link
Contributor Author

Waiting for this PR to merge in first - #30249

@mergify
Copy link
Contributor

mergify bot commented Oct 30, 2025

This pull request has conflicts when rebasing. Could you fix it @cyndichin? 🙏

@cyndichin cyndichin force-pushed the cc/FXIOS-13648_add-recent-searches-to-initial-UI branch from 5457de6 to d6f905d Compare October 30, 2025 17:48
@cyndichin
Copy link
Contributor Author

Waiting for this PR to merge in first - #30249

Rebased and strings should be up to date.

@cyndichin cyndichin marked this pull request as ready for review October 30, 2025 17:49
@cyndichin cyndichin requested a review from a team as a code owner October 30, 2025 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants