Skip to content

Conversation

@soncuteanca
Copy link
Collaborator

@soncuteanca soncuteanca commented Dec 3, 2025

Relevant Links

Bugzilla: 1999820
TestRail: 3029071

Description of Code / Doc Changes

  • Add adaptive history records removal test
  • Refactoring work:
    • rename selector to avoid confusions, both bookmarks and history items uses the same CSS class "bookmark-item" in the hamburger menu UI.
    • update the existing adaptive history test with new methods to follow the refactoring best practice
    • replace the line of code with the corresponding existing method in test_deleted_page_not_remembered.py

Process Changes Required

Mark the relevant boxes:

  • Adds a dependency (rerun pipenv install)
  • Changes the BasePage
  • Changes or creates a BOM/POM (name the object model): _
  • Changes CI flow
  • Changes scheduled Beta or DevEdition
  • Changes Git hooks or Github settings
  • Changes L10n harness

Screenshots or Explanations

If you need to explain your code, do it here.

Comments or Future Work

Do we need to start another PR soon to address something you saw while working on this?

Workflow Checklist

  • Please request reviewers
  • If this is an unblocker, please post in Slack.
  • If asked to address comments, please resolve conversations.
  • If asked to change code, please re-request review from the person who wanted changes.

Thank you!

@soncuteanca soncuteanca changed the title Anca/adaptive history records removed Anca/Adaptive history records removal test + some refactoring Dec 3, 2025
@soncuteanca soncuteanca marked this pull request as ready for review December 3, 2025 16:10
@soncuteanca soncuteanca force-pushed the anca/adaptive-history-records-removed branch from 4c99083 to 68e2a4d Compare December 5, 2025 07:40
Copy link
Collaborator

@vsangereanMOZ vsangereanMOZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good

@soncuteanca soncuteanca merged commit f8933c8 into main Dec 5, 2025
15 checks passed
@soncuteanca soncuteanca deleted the anca/adaptive-history-records-removed branch December 5, 2025 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants