PCF 651 mode analysis #951
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for mozilla-perfcompare ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
misspran
force-pushed
the
PCF-651-mode-analysis
branch
from
40eb036 to
1af288a
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #951 +/- ##
==========================================
+ Coverage 95.00% 95.28% +0.27%
==========================================
Files 101 102 +1
Lines 2845 2885 +40
Branches 602 621 +19
==========================================
+ Hits 2703 2749 +46
+ Misses 140 135 -5
+ Partials 2 1 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…nnWhitneyCompareMetrics, update direction interpertation
misspran
force-pushed
the
PCF-651-mode-analysis
branch
from
520d2cf to
fb6d255
Compare
kala-moz
requested changes
Oct 29, 2025
Contributor
There was a problem hiding this comment.
Just a few UI suggestions: get the box's edge to align with the component's box above it; add padding to the Medium Shift column; get the name for the first column; and if the Medium Shift column as not values, insert 0 or N/A whichever is appropriate.
misspran
force-pushed
the
PCF-651-mode-analysis
branch
from
0c8b19e to
ccbe3bc
Compare
misspran
force-pushed
the
PCF-651-mode-analysis
branch
from
a9e1ffc to
6b186a1
Compare
misspran
force-pushed
the
PCF-651-mode-analysis
branch
from
6b186a1 to
1246737
Compare
misspran
force-pushed
the
PCF-651-mode-analysis
branch
from
d931e60 to
808b1d7
Compare
misspran
force-pushed
the
PCF-651-mode-analysis
branch
from
24b1504 to
44d177c
Compare
misspran
force-pushed
the
PCF-651-mode-analysis
branch
2 times, most recently
from
3d93c70 to
db9750f
Compare
misspran
force-pushed
the
PCF-651-mode-analysis
branch
2 times, most recently
from
a4e3de8 to
e7ff85f
Compare
… add getModeInterpretation test
misspran
force-pushed
the
PCF-651-mode-analysis
branch
from
e7ff85f to
1ce1709
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needs for backend PR to be merged in: #9039
Added ModeInterpretation Component
Figma Link
example link
multimodal example, scroll down to fetch_content, first android version
Scroll to cross_origin_pageload, first item linux
Some of the feedback from last Thursday will require for this to have some backend updates in this PR: