Ref #977 - Moving back to 400 responses for stale expected values after fastly migration #983
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…er fastly migration
leplatrem
requested changes
Aug 26, 2025
| # Check if client is trying to go back in time, return 400 response | ||
| if qs_expected > 0 and qs_expected < qs_since: | ||
| response = httpexceptions.HTTPNoContent() | ||
| response = httpexceptions.HTTPBadRequest() |
Contributor
There was a problem hiding this comment.
See changes of #982
Suggested change
| response = httpexceptions.HTTPBadRequest() | |
| raise_invalid( | |
| request, | |
| name="_expected", | |
| location="querystring", | |
| description="`_expected` parameter cannot be lower than `_since`", |
Contributor
|
maybe just revert #982 instead |
Contributor
|
Please note that 400 requests won't be cached by the CDN (see https://github.com/mozilla/webservices-infra/pull/7525) (This should be OK though since we don't reach the DB before returning them) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref #977 - Moving back to 400 responses for stale expected values after fastly migration
Leaving in draft for now, will merge when we are ready to test.