Skip to content

Jdk 11 262 #1927

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Jdk 11 262 #1927

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0e2bb21
revert org.gradle.toolchains.foojay-resolver-convention to version 0.…
rbri Jun 1, 2025
c0a8fbd
had to update this to make the check working again
rbri Jun 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion settings.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
plugins {
id 'org.gradle.toolchains.foojay-resolver-convention' version '1.0.0'
id 'org.gradle.toolchains.foojay-resolver-convention' version '0.10.0'
id 'org.jetbrains.kotlin.jvm' version '2.1.21' apply false
}
rootProject.name = 'rhino-root'
Expand Down
2 changes: 1 addition & 1 deletion tests/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ test {

systemProperty 'test262properties', System.getProperty('test262properties')
if (System.getProperty('updateTest262properties') != null) {
if (System.getenv("RHINO_TEST_JAVA_VERSION") != "11") {
if ("11".equals(System.getenv("RHINO_TEST_JAVA_VERSION"))) {
Copy link
Contributor

@ZZZank ZZZank Jun 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing a ! here ? The new condition seems to being doing the opposite of the original one

Copy link
Collaborator Author

@rbri rbri Jun 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:-) omg
will check that tomorrow....

System.out.println("Test262 properties update is only accurate on Java 11 and you have " + JavaVersion.current())
System.out.println("Set RHINO_TEST_JAVA_VERSION in the environment to use this feature")
throw new Exception("Incorrect Java version for Test 262 properties update")
Expand Down
Loading