feat: implement rokt launcher into initForwarder#2
Merged
alexs-mparticle merged 15 commits intodevelopmentfrom Mar 7, 2025
Merged
feat: implement rokt launcher into initForwarder#2alexs-mparticle merged 15 commits intodevelopmentfrom
alexs-mparticle merged 15 commits intodevelopmentfrom
Conversation
1 task
* development: Set up initial kit configuration (#3)
Ethaywien
reviewed
Mar 6, 2025
crisryantan
commented
Mar 6, 2025
alexs-mparticle
requested changes
Mar 6, 2025
alexs-mparticle
requested changes
Mar 7, 2025
rmi22186
reviewed
Mar 7, 2025
Collaborator
rmi22186
left a comment
There was a problem hiding this comment.
great work getting this going! i have some minor comments. nothing blocking release though.
Comment on lines
+57
to
+66
| if (window['Rokt'] && eventQueue.length > 0) { | ||
| for ( | ||
| var i = 0; | ||
| i < eventQueue.length; | ||
| i++ | ||
| ) { | ||
| processEvent(eventQueue[i]); | ||
| } | ||
| eventQueue = []; | ||
| } |
Collaborator
There was a problem hiding this comment.
Is there a use case for an mparticle event to be passed to the Rokt SDK for processing? I don't think so. It doesn't hurt to have this, but if Rokt never processes mParticle events, then this can be removed.
Suggested change
| if (window['Rokt'] && eventQueue.length > 0) { | |
| for ( | |
| var i = 0; | |
| i < eventQueue.length; | |
| i++ | |
| ) { | |
| processEvent(eventQueue[i]); | |
| } | |
| eventQueue = []; | |
| } |
Co-authored-by: Robert Ing <ring@mparticle.com>
alexs-mparticle
approved these changes
Mar 7, 2025
alexs-mparticle
pushed a commit
that referenced
this pull request
Mar 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instructions
developmentSummary
Testing Plan
Reference Issue (For mParticle employees only. Ignore if you are an outside contributor)