feat: log custom event logging for selectPlacement by jaissica12 · Pull Request #52 · mparticle-integrations/mparticle-javascript-integration-rokt

jaissica12 · 2026-01-16T21:58:04Z

Summary

Adde mParticle custom event logging (Other type) every time selectPlacements is called
WILL CHANGE THE TARGET BRANCH WHEN MAIN AND DEVELOPMENT ARE IN SYNC

Testing Plan

Added unit tests

Copilot

Pull request overview

This PR adds mParticle custom event logging to track every selectPlacements call for improved visibility and troubleshooting. Each time selectPlacements is invoked, a custom event of type "Other" (EventType 8) is logged with both the developer-passed attributes and the final merged attributes sent to Rokt.

Changes:

Added a new logSelectPlacementsEvent function that logs custom events with both original and final attributes as JSON strings
Modified selectPlacements to accept and track devPassedAttributes parameter
Added comprehensive unit tests for the new logging functionality

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File	Description
src/Rokt-Kit.js	Added constant for event name, modified selectPlacements to capture devPassedAttributes, and implemented logSelectPlacementsEvent function
test/src/tests.js	Added mParticle.logEvent mock and comprehensive test suite covering various scenarios for the new logging functionality

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

src/Rokt-Kit.js

Copilot

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

src/Rokt-Kit.js

test/src/tests.js

src/Rokt-Kit.js

test/src/tests.js

src/Rokt-Kit.js

…y object and update tests

Copilot

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

test/src/tests.js

src/Rokt-Kit.js

test/src/tests.js

src/Rokt-Kit.js

…butes to finalAttributes

src/Rokt-Kit.js

Copilot

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

src/Rokt-Kit.js

test/src/tests.js

# [1.14.0](v1.13.1...v1.14.0) (2026-02-04) ### Features * log custom event logging for selectPlacement ([#52](#52)) ([abd548f](abd548f)) * skip attaching the launcher when its embedded and update tests ([#53](#53)) ([f485b50](f485b50))

feat: log custom event logging for selectPlacement

477b9ae

jaissica12 requested a review from Copilot January 16, 2026 21:58

Copilot started reviewing on behalf of jaissica12 January 16, 2026 21:58 View session

Copilot AI reviewed Jan 16, 2026

View reviewed changes

src/Rokt-Kit.js Show resolved Hide resolved

jaissica12 changed the base branch from main to development January 16, 2026 22:02

jaissica12 changed the base branch from development to main January 16, 2026 22:04

add check in logSelectPlacementsEvent

2a0a5f3

jaissica12 requested a review from Copilot January 16, 2026 22:25

Copilot started reviewing on behalf of jaissica12 January 16, 2026 22:26 View session

Copilot AI reviewed Jan 16, 2026

View reviewed changes

src/Rokt-Kit.js Outdated Show resolved Hide resolved

test/src/tests.js Show resolved Hide resolved

src/Rokt-Kit.js Outdated Show resolved Hide resolved

test/src/tests.js Show resolved Hide resolved

jaissica12 requested review from alexs-mparticle and rmi22186 January 16, 2026 22:30

alexs-mparticle requested changes Jan 21, 2026

View reviewed changes

src/Rokt-Kit.js Outdated Show resolved Hide resolved

src/Rokt-Kit.js Outdated Show resolved Hide resolved

rename devPassedAttributes to debugAttributes, add helper to stringif…

f81b579

…y object and update tests

jaissica12 requested a review from Copilot January 21, 2026 23:30

Copilot started reviewing on behalf of jaissica12 January 21, 2026 23:30 View session

Copilot AI reviewed Jan 21, 2026

View reviewed changes

test/src/tests.js Show resolved Hide resolved

src/Rokt-Kit.js Outdated Show resolved Hide resolved

test/src/tests.js Show resolved Hide resolved

src/Rokt-Kit.js Show resolved Hide resolved

fix typo and update tests

5297654

jaissica12 requested a review from alexs-mparticle January 21, 2026 23:51

rename debugAttributes to initialAttributes and selectPlacementsAttri…

3bb1261

…butes to finalAttributes

alexs-mparticle requested changes Jan 23, 2026

View reviewed changes

src/Rokt-Kit.js Outdated Show resolved Hide resolved

src/Rokt-Kit.js Outdated Show resolved Hide resolved

cleanup EVENT_TYPE_OTHER var

f76a5f9

jaissica12 requested a review from alexs-mparticle January 23, 2026 19:19

alexs-mparticle requested a review from Copilot January 23, 2026 21:01

Copilot started reviewing on behalf of alexs-mparticle January 23, 2026 21:02 View session

alexs-mparticle approved these changes Jan 23, 2026

View reviewed changes

Copilot AI reviewed Jan 23, 2026

View reviewed changes

src/Rokt-Kit.js Show resolved Hide resolved

src/Rokt-Kit.js Outdated Show resolved Hide resolved

src/Rokt-Kit.js Outdated Show resolved Hide resolved

remove initialAttributes logging from selectPlacements

87355e7

jaissica12 mentioned this pull request Jan 30, 2026

feat: add attribute logging in selectPlacements mParticle/mparticle-web-sdk#1143

Merged

4 tasks

rmi22186 reviewed Jan 30, 2026

View reviewed changes

test/src/tests.js Show resolved Hide resolved

rmi22186 approved these changes Jan 30, 2026

View reviewed changes

jaissica12 changed the base branch from main to development January 30, 2026 15:31

jaissica12 merged commit abd548f into development Feb 3, 2026
6 of 8 checks passed

Conversation

jaissica12 commented Jan 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Testing Plan

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

jaissica12 commented Jan 16, 2026 •

edited

Loading