add a backup for the environment variables named TIMEOUT, QUIT, `…#8
Open
omar-bz wants to merge 1 commit intomrako:masterfrom
Open
add a backup for the environment variables named TIMEOUT, QUIT, `…#8omar-bz wants to merge 1 commit intomrako:masterfrom
TIMEOUT, QUIT, `…#8omar-bz wants to merge 1 commit intomrako:masterfrom
Conversation
|
This looks like a fix to #4 |
This was referenced Oct 25, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
when i was working with a node server I noticed that the app is not working after adding this script and the problem was that the env var named PORT is overridden by the script.
So to fix this and for all I changed the code to make a backup for each of TIMEOUT, QUIET, PORT, HOST.