Fix Hang in GstPipelineHandler::Stop() and VS build #49
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a fix for the same problem as XPav had and it is the solution provided in the comment: mrayy#48 Also fixed that the VS solution could be built, by removing flag and files from the build.
- Added fire method when progress is messaged and more information in the error function to be handle in custom classes. - CustomVideoStreamer: handles progress and error from pipeline in order to inform the user if the stream is connected or not to the server. - By reading the progress messages we can see if the stream has connected or the server is not found. - By reading the error message we can see if the server fails.
Owner
|
Thank you for this PR. I will try to test it over the weekend |
|
Hi |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fix for the same problem as XPav had and it is the solution provided in the comment: #48
Also fixed that the VS solution could be built, by removing flag and files from the build.