-
Notifications
You must be signed in to change notification settings - Fork 10
Feature/sw 3719 rotary milestone 1 end of september #1839
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
irlaec
wants to merge
5
commits into
alpha
Choose a base branch
from
feature/SW-3719-rotary-milestone-1-end-of-september
base: alpha
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
) * Add laser cutter mode switch * Update octoprint_mrbeam/static/js/app/view-models/working-area.js Co-authored-by: khaledsherkawi <[email protected]> * Update octoprint_mrbeam/static/js/app/view-models/working-area.js Co-authored-by: khaledsherkawi <[email protected]> * Update octoprint_mrbeam/static/js/app/view-models/working-area.js Co-authored-by: khaledsherkawi <[email protected]> * Update octoprint_mrbeam/static/js/app/view-models/working-area.js Co-authored-by: khaledsherkawi <[email protected]> * Update octoprint_mrbeam/static/js/app/view-models/working-area.js Co-authored-by: khaledsherkawi <[email protected]> * Update octoprint_mrbeam/static/js/app/view-models/working-area.js Co-authored-by: khaledsherkawi <[email protected]> * Update octoprint_mrbeam/static/js/app/view-models/working-area.js Co-authored-by: khaledsherkawi <[email protected]> * Update octoprint_mrbeam/static/js/app/view-models/working-area.js Co-authored-by: khaledsherkawi <[email protected]> * Update octoprint_mrbeam/static/js/app/view-models/working-area.js Co-authored-by: khaledsherkawi <[email protected]> * Update octoprint_mrbeam/static/js/app/view-models/working-area.js Co-authored-by: khaledsherkawi <[email protected]> * Run pre-commit * wip switch component * Everything but the translations * Mark strings for translation * Code cleanup * Run pre-commit --------- Co-authored-by: khaledsherkawi <[email protected]>
…1815) * Select materials csv based on laser cutter mode * Rework custom materials logic * Add unit tests * Pass laser cutter mode to materials * Update octoprint_mrbeam/util/material_csv_parser.py Co-authored-by: khaledsherkawi <[email protected]> * Update octoprint_mrbeam/util/material_csv_parser.py Co-authored-by: khaledsherkawi <[email protected]> * Update octoprint_mrbeam/materials.py Co-authored-by: khaledsherkawi <[email protected]> * Improve method name * Add test for empty custom materials --------- Co-authored-by: khaledsherkawi <[email protected]>
#1814) * SW-3833 fix 1027 error (#1798) * improve error handling for fan pcb * only report hardware malfunction for fan stuff once and don't flood the log * dimiss notifications * don't cancel laser job on fan not spinning error only pause it and only report the errors if they appear outside the boot grace periode * SW-3537 fix laserhead none will crash plugin (#1800) * prevent recursive log calls * fix race condition for failing test * SW-3537 improve recursive log prevention (#1801) improve recursive log prevention * SW-3833 fix bug in logic (#1802) * SW-3915 fix final dust extraction phase 1 not working (#1808) * SW-3291 Quick text fonts are not loaded causing bounding box discrepancies (#1806) * SW-3291 Update cluster if it includes quickText elements * SW-3291 Refactor url2png and redraw canvas if url contains quickText elements * SW-3291 Refactor render-fills.js * SW-3291 Handle caught error * SW-3291 Add quickText font load timeout as a constant * SW-3291 Add includesQuickText parameter to all generatePNGFromURL methods used on QuickText elements * SW-3291 Add log messages on draw and clear canvas * SW-3291 Fix comments * SW-3291 Fix comments * SW-3291 Fix unneeded log variable * SW-3291 Add to analytics on issue detection * Revert "SW-3291 Add to analytics on issue detection" This reverts commit 45d1610. * SW-3291 Add Todo comment * SW-3291 Fix typo * First version * Revert "Merge branch 'alpha' into SW-3812-frontend-refresh-the-web-page-if-the-laser-cutter-mode-flips" This reverts commit 1a8688a, reversing changes made to e26217b. * Switch to using laser cutter mode string instead of id * Fix log --------- Co-authored-by: Josef-MrBeam <[email protected]> Co-authored-by: khaledsherkawi <[email protected]>
* SW-3726 Add a laser cutter mode model class * SW-3726 Add a laser cutter mode service class * SW-3726 Implement the laser cutter mode service * SW-3726 Send laser cutter mode details to frontend * SW-3726 Refactor to fix code smells * SW-3726 Fix bug * SW-3726 Fix duplication * Fix laser cutter mode model and add tests * Laser cutter mode service fixes and tests * Docstrings in Google style * Change laser cutter mode model to only use id * implement todos * Cleanup * Fix reding laser_cutter_mode from settings * Fix * Fix * Add laser cutter mode change backend code --------- Co-authored-by: irlaec <[email protected]>
…class and use it to implement rotary profile (#1831) * SW-3951 Add profile class The profile class is a modified version of the printerProfile class from OctoPrint. It has been modified to be able to serve as a parent class that can be implemented for different purposes and for different profile schemas. * SW-3951 Add laser cutter profile model * SW-3951 Add laser cutter profile service This class implements the profile parent class to be used for laser cutter profiles. * SW-3951 Add laser cutter profiles to constants * SW-3951 Refactor services * SW-3951 Remove duplicated class * SW-3951 Refactor laser cutter profiles viewmodel * SW-3951 Implement the new laser cutter profile service * SW-3951 Set default profile as a constant * SW-3951 Update the profile initialization * SW-3951 Refactor profile initialization * SW-3951 Refactor laser cutter profiles * SW-3951 Remove unnecessary parameter * SW-3951 Fix bug * SW-3951 Add line breaks to hard refresh window * SW-3807 Modify GRBL rate and acceleration * SW-3727 Implement Rotary homing mechanism * SW-3951 Refactor updating the laser cutter profile * SW-3951 Fix bug * SW-3951 Fix order * SW-3815 Add soft limits to the rotary profile * SW-3951 Clean up old profile files * SW-3951 Fix default profile * SW-3951 Handle 2C series * SW-3951 Clean up and fix code smells and PR review notes * SW-3951 Fix bug * SW-3951 Add PR review feedback * SW-3857 Add unit tests for __init__.py changes * SW-3857 Add unit tests for __init__.py changes * SW-3857 Rearrange unit tests structure * SW-3857 Add unit tests for some profile.py methods * SW-3857 Update unit tests for some profile.py methods * SW-3857 Add unit tests for some profile.py methods
|
✅ Linked to Epic SW-3719 · Rotary - Phase 1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.