Link list should also have html entities decoded. #102
Draft
diolemo wants to merge 1 commit intomtibben:masterfrom
Draft
Link list should also have html entities decoded. #102diolemo wants to merge 1 commit intomtibben:masterfrom
diolemo wants to merge 1 commit intomtibben:masterfrom
Conversation
Owner
|
Please add tests to demonstrate the issue |
|
Is this still going to happen or are we waiting on tests ? |
Owner
|
Waiting on tests |
Collaborator
|
Still waiting on tests. |
Collaborator
|
Marking this PR as draft. Please provide tests and, when ready, put it back to ready status. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
html_entity_decodeis executed after links have been extracted but before the link list is built so html entities will still be present in the links.This PR fixes that issue, for known entities.