-
-
Notifications
You must be signed in to change notification settings - Fork 32.8k
[code-infra] Update internal deps ranges to be non breaking #47454
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[code-infra] Update internal deps ranges to be non breaking #47454
Conversation
97fc462 to
5d188a9
Compare
Netlify deploy previewhttps://deploy-preview-47454--material-ui.netlify.app/ Bundle size report
|
5d188a9 to
e0ec9c7
Compare
| "cross-fetch": "^4.1.0", | ||
| "gm": "^1.25.1", | ||
| "prettier": "^3.6.2", | ||
| "prettier": "~3.6.2", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wouldn't bother trying to control it this fine grained. If we want to minimize lock file updates causing breakage, then let's just pin every dev dependency. Renovate will update them weekly anyway, we don't need the lockfile update to bump their patch version.
How do you feel about we do
{
"packageRules": [
{
"matchDepTypes": ["devDependencies"],
"rangeStrategy": "pin"
}
]
}?
Keep in mind we grouped all (otherwise ungrouped) devdependencies as well in renovate, so one way or the other, there will be a PR with all of them updated and it will break CI anyway, just not on the lockfile update.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wouldn't bother trying to control it this fine grained. If we want to minimize lock file updates causing breakage, then let's just pin every dev dependency.
The idea is that only a handful of dependencies don't follow semver: prettier, typescript (but is less often an issue), and our internal packages. They are the only ones who need a ~ range or pin?
pin every dev dependency
We would lose the benefit of the lock file cleaning with this (low priority security fixes, deduplicate, mass update of low risk dependencies), if we pin, no?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We would lose the benefit of the lock file cleaning with this (low priority security fixes, deduplicate, mass update of low risk dependencies), if we pin, no?
No not at all, Currently the lockfile maintenance is doing double duty:
- update all of our direct dependencies dev and prod, within their version range
- update all transitive dependencies + dedupe
But 1. is already handled by regular renovatebot PRs, no need to do it as well in lockfile maintenance. And we do those more frequently than lock file maintenance anyway. We can keep lockfile maintenance for prod and transitive dependencies only.
|
Closing as all dev dependencies will be pinned during the next renovate update cycle |
Replicate mui/base-ui#3405 (review)