[material][Rating] Fix keyboard navigation behavior in Safari #47461
+571
−4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR improves the keyboard accessibility and navigation behavior of the Rating component. It primarily focuses on inconsistent/incorrect behavior in Safari. This is because the Safari browser handles focus, radio navigation, and keyboard events differently from other browsers. As a result, keyboard users experienced (BUG):
This PR makes the Rating component fully keyboard-accessible and consistent across all major browsers.
Fix implemented
This PR introduces several improvements that together standardize keyboard behavior:
Cross-browser key handling
"Left","Right","Up","Down"event keys.nextValueForKeyhelper.Reliable, predictable focus behavior (roving
tabIndex)value == null, the “empty” radio hastabIndex=0.tabIndex=0.tabIndex=-1.Single-step arrow key navigation
event.defaultPreventedinsidehandleKeyDownso that:Consistent behavior across states
Tests
pnpm test:unit -- Ratingpasses locally.Related issue
Fixes #34202