Fix dupes in browser history #40
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
👷 Deploy request for multi-website pending review.Visit the deploys page to approve it
|
👷 Deploy request for multi-site-preprod-core-texts pending review.Visit the deploys page to approve it
|
👷 Deploy request for multi-site-app-test pending review.Visit the deploys page to approve it
|
👷 Deploy request for multi-site-preprod pending review.Visit the deploys page to approve it
|
👷 Deploy request for datami-documentation pending review.Visit the deploys page to approve it
|
👷 Deploy request for datami pending review.Visit the deploys page to approve it
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Browsing on the https://www.multi.coop website seems to duplicate every page in browser history. This breaks the intuitive nature of the browser's back button, where users have to press multiple times to go back one page.
For example, loading the website and clicking once on the "Notre offre de service" button creates the following history:
Looking at the network queries, it looks like remote markdown content is also requested twice on page load.
This PR fixes the duplicates in history by removing an obsolete (?)
updateUrlcall when mouting.I'm not too familiar with the tech stack, but it looks like the site behaves the same without this line.
However, this PR doesn't fix the multiple calls to remote markdown content. So this might be a band-aid on a deeper issue ?