Added ability to change audio drivers without restarting #30950
Conversation
igorkorsukov
force-pushed
the
audio/change_api_norestart
branch
from
28b3df6 to
8852934
Compare
| //! Channels allow 10 threads by default. Here we're increasing that to the maximum... | ||
| //! If this is not enough, then we need to make sure that the callback is called in one thread, | ||
| //! or use something else here instead of channels, some kind of queues. | ||
| const int _max_threads = 100; |
There was a problem hiding this comment.
I already encountered a "thread pool exhausted" even without this PR
On my machine, the TaskScheduler already has 7 threads, but that still means it's currently already used by three other threads, for which I don't really have an explanation
It would be great if we could somehow lift the restriction of a fixed maximum number of threads. We can keep bumping the number, but that doesn't feel entirely safe to me.
There was a problem hiding this comment.
I have no idea yet how to make an unlimited number without a mutex.
But I think we can reclaim unused ones.
So, the "sender thread" should be freed at some point, or reused.
There was a problem hiding this comment.
or just don't use channels for this place... but use a pure queue
|
oops... I was cleaning my fork and deleted this branch... I'll restore it. |
|
replaced by #30989 |
4 participants
No description provided.