Skip to content

Use urlquote to allow passwords with special characters. #235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
espoirMur wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Use urlquote to allow passwords with special characters. #235

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions scrapydweb/utils/setup_database.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
import os
import re
import sys
from urllib.parse import quote as urlquote


DB_APSCHEDULER = 'scrapydweb_apscheduler'
Expand Down Expand Up @@ -98,7 +99,7 @@ def setup_mysql(username, password, host, port):
# Run scrapydweb: ModuleNotFoundError: No module named 'MySQLdb'
pymysql.install_as_MySQLdb()

conn = pymysql.connect(host=host, port=int(port), user=username, password=password,
conn = pymysql.connect(host=host, port=int(port), user=username, password=urlquote(password),
charset='utf8', cursorclass=pymysql.cursors.DictCursor)
cur = conn.cursor()
for dbname in DBS:
Expand Down Expand Up @@ -131,7 +132,7 @@ def setup_postgresql(username, password, host, port):
except (ImportError, AssertionError):
sys.exit("Run command: %s" % install_command)

conn = psycopg2.connect(host=host, port=int(port), user=username, password=password)
conn = psycopg2.connect(host=host, port=int(port), user=username, password=urlquote(password))
conn.set_isolation_level(0) # https://wiki.postgresql.org/wiki/Psycopg2_Tutorial
cur = conn.cursor()
for dbname in DBS:
Expand Down