- 
                Notifications
    
You must be signed in to change notification settings  - Fork 17
 
DSWx-NI triggering logic #1226
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
DSWx-NI triggering logic #1226
Conversation
| 
           Proposed TODO before this is merged: 
 here's the stack trace I'm getting from failing jobs:  | 
    
| 
           for MGRS db staging - for testing lambda triggered as query job -  | 
    
| 
           can you flatten the commits? (reset branch to parent develop commit, then force push the reported changes. This will simplify the commit history)  | 
    
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changes look good.
you may want to move the _extract* methods outside of the CmrQuery class (or just leave them in. i would organize them separately since they are low level, to keep the methods at a higher level of abstraction than parsing string/granule).
Some of the docstrings are redundant, and simply repeat the function name, so you could omit those docstrings without a loss in readability.
| 
           Hyun and I had a conversation offline and talked about some changes: 
  | 
    
| 
           Sample command to download data from HTTPS url  | 
    
| 
           @ryanghunter getting this error  | 
    
| 
           The following command should trigger three DSWx-NI jobs, since the track number 155 and frame number 67 are used by MS_155_64, MS_155_65, and MS_155_66:  | 
    
Using more flexible datetime parsing rather than introduce endpoint/env param to distinguish between UAT and OPS.
Purpose
This PR adds DSWx-NI triggering logic support to the daac_data_subscriber system. It supports time based queries and native-id queries natively through the daac_data_subscriber top-level script.
Proposed Changes
--query-replacement-fileoptions to daac_data_subscriber for using pre-canned json instead of query for testingIssues
Testing