Add strict typing #20
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Casper Beyer <[email protected]>
Signed-off-by: Casper Beyer <[email protected]>
Signed-off-by: Casper Beyer <[email protected]>
There was a problem hiding this comment.
Pull Request Overview
This PR adds comprehensive type hints to the nkeys library to support PEP 561 typed package compliance. The changes enable better IDE support, type checking with mypy, and improved code documentation through type annotations.
- Adds type annotations to all functions, methods, and class attributes
- Configures the package as PEP 561 compliant with a
py.typedmarker file - Updates mypy configuration to enable strict type checking with Python 3.8
Reviewed Changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| pyproject.toml | Adds py.typed to package data, updates mypy to strict mode with Python 3.8, and configures third-party library overrides |
| nkeys/py.typed | Empty marker file indicating the package supports type hints per PEP 561 |
| nkeys/init.py | Adds comprehensive type annotations to all functions, methods, class attributes, and improves null safety checks |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.