Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds a new per-process network statistics section to the output, providing a brief summary of socket usage and TCP network counters, and updates documentation and tests accordingly. The main changes include collecting and displaying aggregated network stats, tracking per-interface socket usage, and ensuring robust test coverage for the new functionality.
New network statistics feature:
[network]section to the process output, showing total sockets, breakdown by protocol (TCP/UDP/UNIX), TCP packet and byte counters, retransmits, drops, and per-interface socket counts. (src/elf_det.c[1] [2]struct netdev_countand related helpers for tracking and displaying socket counts per network device/interface. (src/elf_det.h[1] [2]Documentation updates:
README.md) and technical documentation (docs/TECHNICAL.md). (README.md[1] [2];docs/TECHNICAL.md[3] [4]docs/TESTING.md[1] [2]Testing improvements:
[network]section and its key fields in the output for various processes. (e2e/qemu-test.sh[1] [2] [3]add_netdev_counthelper to ensure correct aggregation and boundary handling. (src/elf_det_tests.csrc/elf_det_tests.cR500-R540)Miscellaneous:
src/elf_det.c[1]src/elf_det.h[2]These changes collectively provide users with a concise overview of a process's network activity and resource usage, and improve observability and testability for the new feature.