Tests: introduce HS compat test with TOR client #63
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aarani
force-pushed
the
testHSWithTorClient
branch
from
cf6a445 to
a4cb1fa
Compare
Member
|
Is this .NETStandard2.0 compatible? |
Collaborator
Author
NOnion itself is not touched, I only upgraded the test project. |
Member
^ |
aarani
force-pushed
the
testHSWithTorClient
branch
16 times, most recently
from
faf99ab to
657c560
Compare
This commit introduces a test to make sure our hidden service hosts are accessible by official tor client. Testing only with NOnion's TorServiceClient can cause mask problems because it shares lots of code with TorServiceHost (especially crypto stuff) and mistakes there can go unnoticed. Upgrade to .NET 6 was necessary to be able to use SocksV5 (which is what tor gives us) as proxy for HttpClient. Due to some problem with NUnit not writing test-by-test output (whether it passed or failed), I had to upgrade even furthur into .NET 7. NUnit was also updated to latest version because it was causing issue where some unrelated tests would fail in .NET7 (maybe the Retry attributed wasn't working).
aarani
force-pushed
the
testHSWithTorClient
branch
2 times, most recently
from
5088bfe to
35d51d2
Compare
Collaborator
Author
|
This is done, I ran the tests multiple times +12 times, the flakiness is gone. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrade to .NET 6 was necessary to be able
to use SocksV5 (which is what tor gives us)
as proxy for HttpClient.