Skip to content

fix: Prevent conflicting provisioning requests #1025

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
morgsmccauley merged 2 commits into from
Nov 12, 2024
Merged

fix: Prevent conflicting provisioning requests #1025

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4a949af
fix: Prevent conflicting provisioning requests
morgsmccauley Nov 11, 2024
ecf62f4
test: Mock timer in lifecycle tests
morgsmccauley Nov 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions coordinator/src/handlers/data_layer.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,6 +88,7 @@ impl DataLayerHandlerImpl {
pub fn connect(runner_url: &str) -> anyhow::Result<Self> {
let channel = Channel::from_shared(runner_url.to_string())
.context("Runner URL is invalid")?
.rate_limit(1, std::time::Duration::from_secs(5))
.connect_lazy();
let client = DataLayerClient::new(channel);

Expand Down
4 changes: 4 additions & 0 deletions coordinator/src/lifecycle.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -699,6 +699,8 @@ mod tests {

#[tokio::test]
async fn restarts_unhealthy_stream() {
tokio::time::pause();

let config = IndexerConfig::default();
let mut state = IndexerState {
lifecycle_state: LifecycleState::Running,
Expand Down Expand Up @@ -953,6 +955,8 @@ mod tests {

#[tokio::test]
async fn restarts_unhealthy_executor() {
tokio::time::pause();

let config = IndexerConfig::default();
let mut state = IndexerState {
lifecycle_state: LifecycleState::Running,
Expand Down
Loading