Fix infinite loop crash in signup rounds calendar rendering #11179
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add Playwright as dev dependency - Create reusable login helpers for authentication flows - Add database setup utilities for creating test users - Implement configurable permission system via command-line args - Add comprehensive README with usage examples Key features: - setupAndLogin() - one-stop function to create user and login - ensureTestUser() - creates users with specified permissions - No hardcoded convention domains (must be specified per test) - Default: creates regular users with no special permissions - Tests can grant specific permissions as needed Usage: await setupAndLogin(page, 'mycon.test', ['update_convention']); Co-Authored-By: Claude Sonnet 4.5 <[email protected]>
- Add /test-results and /playwright-report to .gitignore - Add comprehensive Playwright section to CLAUDE.md with: - Quick start guide with code examples - Documentation of key helpers (setupAndLogin, ensureTestUser, login) - Permission system explanation - Environment variables reference - Running tests commands - Best practices Co-Authored-By: Claude Sonnet 4.5 <[email protected]>
The while loop on line 214 was checking currentWeek.length < 7 but pushing elements to weekPreview. This caused an infinite loop that crashed the browser tab when rendering signup rounds with certain date configurations. Changed the loop condition to check weekPreview.length instead, which properly increments as elements are added. Co-Authored-By: Claude Sonnet 4.5 <[email protected]>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
…ng or encoding Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
…ng or encoding Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
Contributor
Code Coverage Report: Only Changed Files listed
Minimum allowed coverage is |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Critical Bug Fix
The
ScheduledValuePreviewcomponent had an infinite loop in the calendar rendering code (line 214). When filling empty calendar cells at the end of a month, the while loop checkedcurrentWeek.length < 7but pushed elements toweekPreview, causing the condition to never change. This crashed the browser tab when certain signup round date configurations triggered the calendar preview.Changed:
Test Infrastructure
Added comprehensive Playwright test helpers with:
playwright-tests/README.mdfor full documentationTest Plan
🤖 Generated with Claude Code