FEATURE: Support dimensions and cropping for SVG Images #5658
+161
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jan3k3y
force-pushed
the
task/5652
branch
2 times, most recently
from
9b445d2 to
c528af0
Compare
mficzel
requested changes
Oct 23, 2025
Member
mficzel
left a comment
mficzel
left a comment
There was a problem hiding this comment.
Thanks al lot generally looks fine:
- Please rebase on 9.1 and adjust the target branch
- Inline the for loop in the applySvgAdjustments method as requested seperately
| * @param array<ImageAdjustmentInterface> $adjustments | ||
| * @return ImageInterface | ||
| */ | ||
| protected function applySvgAdjustments(ImageInterface $svgImage, array $adjustments): ImageInterface |
Member
There was a problem hiding this comment.
Can you inline this. The foreach in an external function has no benefit bur makes reading harder.
Member
|
I tried to adjust and rebase this but i am not allowed to push to this branch. I suspect that queo has a policy that will not allow non members to push to queo repositories. Can you move this branch to a personal fork and recreate this pr with allow push from maintainers. |
mficzel
reviewed
Dec 5, 2025
| "enshrined/svg-sanitize": "^0.22.0", | ||
| "neos/imagine": "^3.1.0", | ||
| "imagine/imagine": "*", | ||
| "contao/imagine-svg": "^1.0", |
Member
There was a problem hiding this comment.
This should also be added to the composer json of the neos-development-collection
Member
|
Alternative könnte ich einen neuen branch anlegen und deinen commit cherry picken will das aber ungern ohne dein OK machen |
6 tasks
Author
|
Like this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature: #5652
Upgrade instructions
./flow media:refreshsvgdimensionsChecklist
FEATURE|TASK|BUGFIX!!!and have upgrade-instructions