FEATURE: Add yaml Flow core Neos 9 migrations (previously in rector) #5680
+595
−19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…igration the YamlWithComments which allowed this is a funny beast but a lot of complexity just comments https://github.com/neos/rector/blob/efbff0d060f9cf115c7c99fdcefeb07c488a3273/src/Core/YamlProcessing/YamlWithComments.php#L7 In fusion we add warning comments instead to the beginning of the file which should also server well. In the future we want to evaluate if we can migrate yaml by keeping the current comments - if we manage that we can also probably inject some ourselves cleanly without hacks.
6 tasks
dlubitz
approved these changes
Nov 19, 2025
Contributor
dlubitz
left a comment
dlubitz
left a comment
There was a problem hiding this comment.
Thank you for taking care!
kitsunet
approved these changes
Dec 8, 2025
kitsunet
merged commit 12f6ed9
into
feature/addFusionCoreMigrationForNeos9Update
4 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
based on #5642
migrates the "YamlDimensionConfigRector" and the "YamlRoutePartHandlerRector" to Flow Yaml Source Code Migrations
Upgrade instructions
Review instructions
Changes to neos/rector.
We write warning comments to the top of the file and not inline.
We dont add inline comment notes as attempted explanation.
-> This allows us to simplify Yaml handling to parse and dump without hacky comment handling https://github.com/neos/rector/blob/efbff0d060f9cf115c7c99fdcefeb07c488a3273/src/Core/YamlProcessing/YamlWithComments.php#L7
-> in the case we figure out how to read existing comments and keep them when the file is written again we might also find a solution to inject custom comments along.
Checklist
FEATURE|TASK|BUGFIX!!!and have upgrade-instructions