fix(leanls): migrate to vim.lsp.config #4084
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StamesJames
force-pushed
the
add-leanls-to-lsp-subdir
branch
2 times, most recently
from
650c8bc to
5cb47f2
Compare
Contributor
Author
|
I am not sure if I understand the linter message for |
justinmk
reviewed
Sep 20, 2025
justinmk
reviewed
Sep 20, 2025
lsp/leanls.lua
Outdated
| or vim.fs.dirname(vim.fs.find('.git', { path = fname, upward = true })[1]) | ||
| ) | ||
| end, | ||
| on_new_config = function(config, root_dir) |
Member
There was a problem hiding this comment.
Contributor
Author
There was a problem hiding this comment.
Oh yes I will look into this. I even have read this Issue but than still copied the old config without thinking 😅
StamesJames
force-pushed
the
add-leanls-to-lsp-subdir
branch
from
5cb47f2 to
71a5616
Compare
StamesJames
force-pushed
the
add-leanls-to-lsp-subdir
branch
from
71a5616 to
ef80f9b
Compare
Contributor
Author
|
Like this, it should now call the cmd with the root_dir as before. |
Member
|
Thanks! |
justinmk
changed the title
MattSturgeon
added a commit
to MattSturgeon/nixvim
that referenced
this pull request
Oct 1, 2025
nvim-lspconfig currently doesn't support leanls via the new API, although this is fixed upstream we don't have the fix in our pinned nixpkgs yet. Upstream PR: neovim/nvim-lspconfig#4084
MattSturgeon
added a commit
to MattSturgeon/nixvim
that referenced
this pull request
Oct 1, 2025
nvim-lspconfig currently doesn't support leanls via the new API, although this is fixed upstream we don't have the fix in our pinned nixpkgs yet. Upstream PR: neovim/nvim-lspconfig#4084
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have no experience with the lspconfigs, but I saw that the
leanls.luawas the only one missing inlsp/compared tolua/lspconfig/configs/. I simply copied the old settings and migrated them.This is related to the Issue 427 the lean.nvim repo. I will also write a PR that changes the use of the old
require('lspconfig').leanlstovim.lsp.enableandvim.lsp.configbut this will only work once theleanls.luais inlsp/I tested this PR with an updated
lean.nvimplugin already usingvim.lsp.enableandvim.lsp.congigand it seems to work.