fix(jdtls): increase priority of .git marker and add mvnw and gradlew #4104
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using git directory as last resort before defaulting to pom.xml is important for multi module maven projects. Example of structure: pom.xml submodule-a/pom.xml submodule-b/pom.xml If sumbodule-b depends on submodule-a (common pattern for dto/impl), the parent usually has info about linking the 2 projects (and without that go to definition etc will jump to compiled source that might not be present/up t date). This structure is also fine and do not breaks jdtls: my-project/pom.xml e.g its fine if working directory is git repo root (and this pattern is also much less common than multi module maven projects that without this change break always). Closes neovim#4102 Signed-off-by: Tomas Slusny <[email protected]>
deathbeam
force-pushed
the
fix-jdtls-root-marker
branch
from
25093c5 to
557d01d
Compare
justinmk
reviewed
Sep 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using git directory as last resort before defaulting to pom.xml is important for multi module maven projects. Example of structure:
pom.xml
submodule-a/pom.xml
submodule-b/pom.xml
If sumbodule-b depends on submodule-a (common pattern for dto/impl), the parent usually has info about linking the 2 projects (and without that go to definition etc will jump to compiled source that might not be present/up t date).
This structure is also fine and do not breaks jdtls:
my-project/pom.xml
e.g its fine if working directory is git repo root (and this pattern is also much less common than multi module maven projects that without this change break always).
Closes #4102