Ibexa 5.0+ support #173
Ibexa 5.0+ support #173
Conversation
| abstract: true | ||
| calls: | ||
| - [performAccessChecks, []] | ||
| _defaults: |
There was a problem hiding this comment.
I don't like using autowiring in vendor libraries. I believe autowiring is a great fit for custom project code, but not for something that goes into vendor.
Can you rewrite this not to use autowiring and autoconfiguration?
There was a problem hiding this comment.
I've removed autoconfigure.
Symfony have made it an absolute pain to use AbstractController without using autowiring for its service locator. And it's not possible to just use the full service container either, as AbstractController relies on the service aliases from its locator.
So it's either using autowiring, declaring your own service locator, or rewriting controllers to not extend AbstractController.
Let's just leave autowiring on for controllers. All the arguments are still explicitly declared.
| @@ -1,8 +1,10 @@ | |||
| services: | |||
| _defaults: | |||
There was a problem hiding this comment.
Same remark here about wiring as above.
2 participants
Hello everyone,
I've done some work on the upgrade for Ibexa 5.
I've added the bundle on a fresh Ibexa 5 OSS install and everything seems functional.