Skip to content

CI: cover PHP 8.5 #325

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
staabm wants to merge 35 commits into from
Closed

CI: cover PHP 8.5 #325

staabm wants to merge 35 commits into from

Conversation

@staabm
Copy link
Contributor

@staabm staabm commented Aug 13, 2025 •
edited
Loading

fixes deprecations

PHP Deprecated:  Method SplObjectStorage::attach() is deprecated since 8.5, use method SplObjectStorage::offsetSet() instead in phar:///home/runner/work/phpstan-src/phpstan-src/extension/vendor/phpstan/phpstan/phpstan.phar/vendor/nette/di/src/DI/Resolver.php on line 56
PHP Deprecated:  Method SplObjectStorage::detach() is deprecated since 8.5, use method SplObjectStorage::offsetUnset() instead in phar:///home/runner/work/phpstan-src/phpstan-src/extension/vendor/phpstan/phpstan/phpstan.phar/vendor/nette/di/src/DI/Resolver.php on line 64
PHP Deprecated:  Method SplObjectStorage::contains() is deprecated since 8.5, use method SplObjectStorage::offsetExists() instead in phar:///home/runner/work/phpstan-src/phpstan-src/extension/vendor/phpstan/phpstan/phpstan.phar/vendor/nette/di/src/DI/Resolver.php on line 49
E_DEPRECATED: Method ReflectionProperty::setAccessible() is deprecated since 8.5, as it has no effect

dg and others added 30 commits June 18, 2025 21:33
@dg
github actions updated
007bc0f
@dg
composer: require stable packages outside of nette
b3776b1
@dg
composer: added psr-4 loader
9ab27c6
@dg
tests: improved descriptions
908e6f5
@dg
tests: merges some tests
ca55ed7
@dg
ConnectionPanel: convert templates to Latte-like syntax
5c1ce07
@vojtech-dobes @dg
used generics for Container::createInstance() (nette#323)
6db42d6
@dg
exception: use natural explanatory style
01b29b0
@dg
optimized global function calls
39accab
@dg
opened 3.3-dev
7cdef71
@dg
uses nette/schema 1.3
8990bb8
@dg
uses nette/neon 3.4
499e744
@dg
used attribute Deprecated
4563395
@dg
Definition::generateMethod() replaced with generateCode()
6f68661
@dg
Resolver: used withCurrentServiceAvailable() to control $currentServi…
a8eb347 
…ceAllowed
@dg
added Definitions\Expression
eb6f8df
@dg
PhpGenerator::formatStatement() moved to Statement & Reference
ed2b60a
@dg
Resolver::resolve*Type() moved to Statement & Reference
06a2a70
@dg
Resolver::completeStatement() moved to Statement & Reference
decab76
@dg
NeonAdapter: processing of 'prevent merging' and 'entity to statement…
f36eb1d 
…' moved to visitors
@dg
added FunctionCallable & MethodCallable, expressions representing fir…
9c7619c 
…st-class callables
@dg
opened 4.0-dev
1852e21
@dg
exception messages use [Service ...]\n format [WIP]
b95b0b0 
added Definition::getDescriptor(), Helpers::entityToString()
@dg
annotations @return are no longer supported (BC break)
f7bd6c0
@dg
annotations @var are no longer supported (BC break)
9fb7893
@dg
removed Definition::generateMethod() (BC break)
314762d
@dg
removed support for three ... dots
73c5d17
@dg
removed compatibility for old class names
d01239d
@dg
deprecated magic properties (BC break)
a77b990
@dg
annotations @Inject is deprecated (BC break)
f8e5082
@staabm staabm marked this pull request as ready for review August 13, 2025 11:23
@staabm
Copy link
Contributor Author

staabm commented Aug 13, 2025 •
edited
Loading

remaining errors are unrelated to PHP 8.5

@staabm staabm mentioned this pull request Aug 13, 2025
Merged
@dg
Copy link
Member

dg commented Aug 14, 2025 •
edited
Loading

it is already fixed 5708c32

@staabm staabm closed this Aug 15, 2025
@staabm staabm deleted the php85 branch August 15, 2025 04:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@staabm @dg @vojtech-dobes